[ADD] product_customer_code_picking module v.7.0 #2

tafaRU · 2014-07-03T15:03:53Z

Moving the MP: https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472

gdgellatly · 2014-08-09T06:33:28Z

product_customer_code_picking/stock_picking.py

+            res[move.id] = ''
+            partner = move.picking_id.partner_id
+            if move.picking_id.partner_id.parent_id:
+                partner = move.picking_id.partner_id.parent_id


Hi,

This section of code seems a little restrictive. Consider a 2 level deep partner. It would only take the direct parent. I could be wrong but it feels like what you might want here is a list of ids and use a ('partner_id', in, partner_ids) in your search.

Just a general comment, maybe there is a good reason for ignoring the current partner and any higher up partners.

Agree. Also see my comment at https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472/comments/537661

I'm about to apply some fix to this PR

Some improvements about this at tafaRU#3

lepistone · 2014-08-19T09:10:55Z

The 7.0 branch is now green, please rebase on 7.0 so that we can see if this branch is green as well.

Thanks!

eLBati · 2014-09-19T14:04:59Z

On 09/19/2014 03:57 PM, Leonardo Pistone wrote:

ah wait @tafaRU https://github.com/tafaRU @eLBati
https://github.com/eLBati I don't see the travis build of the last
commits. Do you have any idea what happened?

Uhm, the branch is old and doesn't contain .travis.yml
@tafaRU please rebase

bwrsandman · 2014-10-06T14:55:19Z

Needs a rebase in order to be validated by Travis.

@tafaRU could you do this, or should someone copy this branch?

tafaRU · 2014-10-07T17:11:12Z

Rebasing I get a conflict on the file product_customer_code_picking/stock_picking_view.xml, a bit strange seeing that this branch adds a new module. So I prefer merging instead rebasing.

tafaRU · 2014-10-07T17:15:11Z

I think now the PR can be merged!

gurneyalex · 2014-10-07T20:41:38Z

product_customer_code_picking/__openerp__.py

+    "description": """
+Based on product_customer_code, this module loads in every stock picking
+the customer code defined in the product.
+


Suggested description improvement:

"This module makes the product customer code visible in the stock moves of a picking. "

gurneyalex · 2014-10-07T20:42:52Z

@tafaRU if you're ok with it, could you apply the suggest description improvement above. I'll then merge the PR.

tafaRU · 2014-10-07T20:52:07Z

@gurneyalex just modified the description. Thanks.

lepistone · 2014-10-10T14:36:45Z

It looks like all remarks have been addressed. Thanks to all!

[ADD] product_customer_code_picking module v.7.0

Use @api.multi for has_valuation_move() + fix log message

…eparation_line_lb remove mail thread dep

stock_auto_move : replace utf8 by utf-8, use camelcase in class name

mprove import/export of group_ids and user_ids

[10.0] [FIX] [stock_no_negative] proper indentation, docstring, flake8

Actualizacion rama 11

# This is the 1st commit message: Add module stock_quant_package_product_packaging # The commit message #2 will be skipped: # Add tests # The commit message OCA#3 will be skipped: # Display single_product fields in debug mode

# This is the 1st commit message: Add module stock_quant_package_product_packaging # The commit message OCA#2 will be skipped: # Add tests # The commit message OCA#3 will be skipped: # Display single_product fields in debug mode

# This is the 1st commit message: Add module stock_quant_package_product_packaging # The commit message #2 will be skipped: # Add tests # The commit message #3 will be skipped: # Display single_product fields in debug mode

My feature branch

# This is the 1st commit message: Add module stock_quant_package_product_packaging # The commit message OCA#2 will be skipped: # Add tests # The commit message OCA#3 will be skipped: # Display single_product fields in debug mode

Nicola Malcontenti and others added 27 commits December 18, 2013 18:20

[FIX] Add product_customer_code_picking

8fce27d

[FIX] Modified __openerp__ file

0b9cb10

[FIX] Mod view

d764c3d

[FIX] Mod view

4f5a279

[FIX] View Mod

b856c5e

[FIX] Move bug fix

55ff3dd

[FIX] More fix problem

8316ec7

[FIX] mod to view

fc65e0a

[FIX] field bug fix

e226a6d

[FIX] Changed view

6538923

[FIX] Mod view

20ccc37

[FIX] Picking View Fix

e21e5ea

[FIX] fix product_code problem

eb5d66d

[FIX] Conflict in view

3b6331f

[FIX] Added some Flake8 fix

6500715

[FIX] Added i18n

3ea6bfc

[FIX] Deleted .mo

0e74e68

[FIX] added pot

2ed05aa

[FIX] how to get partner inside of _get_product_customer_code method

82ab210

[FIX] Removed context assignement because not needed

1980c73

[IMP] Better practices

c506552

[IMP] better readibility

9d39539

[IMP] Replaced browse by read to improve performance

9ad6f38

[FIX] keys in manifest file

a32321f

[FIX] Applies some PEP8 cleanup

7f53727

[ADD] contributors section

9954751

[FIX] Added retrieve of parentd_id

bd42b80

gdgellatly reviewed Aug 9, 2014
View reviewed changes

Merge remote-tracking branch 'origin/7.0' into HEAD

baac3c1

tafaRU removed the needs fixing label Oct 7, 2014

gurneyalex reviewed Oct 7, 2014
View reviewed changes

[IMP] module description

a2ea807

lepistone added a commit that referenced this pull request Oct 10, 2014

Merge pull request #2 from tafaRU/adding_product_customer_code_picking

8d37745

[ADD] product_customer_code_picking module v.7.0

lepistone merged commit 8d37745 into OCA:7.0 Oct 10, 2014

tafaRU deleted the adding_product_customer_code_picking branch October 10, 2014 14:37

pedrobaeza pushed a commit that referenced this pull request Jan 20, 2015

Merge pull request #2 from akretion/8.0-stock-cancel-better-new-api

2719e04

Use @api.multi for has_valuation_move() + fix log message

eLBati pushed a commit to eLBati/stock-logistics-workflow that referenced this pull request Sep 10, 2015

Merge pull request OCA#2 from eLBati/8.0-add-stock_picking_package_pr…

ebb09f0

…eparation_line_lb remove mail thread dep

laetitia-gangloff pushed a commit to acsone/stock-logistics-workflow that referenced this pull request Nov 26, 2015

Merge pull request OCA#2 from acsone/8.0-stock-auto-move-lga

2cbd1c2

stock_auto_move : replace utf8 by utf-8, use camelcase in class name

Garamotte pushed a commit to subteno-it/stock-logistics-workflow that referenced this pull request Nov 26, 2015

Merge pull request OCA#2 from acsone/8.0-login_logout-lga

b909ebe

mprove import/export of group_ids and user_ids

levkar mentioned this pull request May 30, 2017

[FIX] Make check in quant level so that it works in manufacturing as well #256

Closed

rousseldenis pushed a commit to acsone/stock-logistics-workflow that referenced this pull request Jul 5, 2017

Merge pull request OCA#2 from darshan-serpent/10-stock_no_negative

9c5defd

[10.0] [FIX] [stock_no_negative] proper indentation, docstring, flake8

zamberjo referenced this pull request in aurestic/stock-logistics-workflow Nov 15, 2019

Merge pull request #2 from OCA/11.0

052a9b9

Actualizacion rama 11

ovscorp mentioned this pull request May 4, 2021

[12.0] [stock_picking_package_preparation/line] Slow and product_uom_qty same as qty done #573

Closed

dreispt pushed a commit to ursais/stock-logistics-workflow that referenced this pull request Apr 29, 2022

Merge pull request OCA#2 from ZavarinArtem/my-feature-branch

3273265

My feature branch

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] product_customer_code_picking module v.7.0 #2

[ADD] product_customer_code_picking module v.7.0 #2

tafaRU commented Jul 3, 2014

gdgellatly Aug 9, 2014

eLBati Aug 28, 2014

eLBati Sep 9, 2014

lepistone commented Aug 19, 2014

eLBati commented Sep 19, 2014

bwrsandman commented Oct 6, 2014

tafaRU commented Oct 7, 2014

tafaRU commented Oct 7, 2014

gurneyalex Oct 7, 2014

gurneyalex commented Oct 7, 2014

tafaRU commented Oct 7, 2014

lepistone commented Oct 10, 2014

[ADD] product_customer_code_picking module v.7.0 #2

[ADD] product_customer_code_picking module v.7.0 #2

Conversation

tafaRU commented Jul 3, 2014

gdgellatly Aug 9, 2014

Choose a reason for hiding this comment

eLBati Aug 28, 2014

Choose a reason for hiding this comment

eLBati Sep 9, 2014

Choose a reason for hiding this comment

lepistone commented Aug 19, 2014

eLBati commented Sep 19, 2014

bwrsandman commented Oct 6, 2014

tafaRU commented Oct 7, 2014

tafaRU commented Oct 7, 2014

gurneyalex Oct 7, 2014

Choose a reason for hiding this comment

gurneyalex commented Oct 7, 2014

tafaRU commented Oct 7, 2014

lepistone commented Oct 10, 2014